From 8699fa2bb4c75670952fee503a58ca4a652627eb Mon Sep 17 00:00:00 2001 From: Hiltjo Posthuma Date: Thu, 11 Oct 2018 19:08:31 +0200 Subject: sfeed_update: replace non-POSIX mktemp with $$ + fix wrong comment "temporary file" -> "temporary directory". --- sfeed_update | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sfeed_update b/sfeed_update index 5ee99ee..374ad5c 100755 --- a/sfeed_update +++ b/sfeed_update @@ -5,6 +5,9 @@ # defaults sfeedpath="$HOME/.sfeed/feeds" +# temporary directory. +sfeedtmpdir="/tmp/sfeed_$$" + # used for processing feeds concurrently: wait until ${maxjobs} amount of # feeds are finished at a time. maxjobs=8 @@ -147,9 +150,8 @@ trap -- "sighandler 2" "INT" trap -- "sighandler 15" "TERM" # load config file. loadconfig "$1" -# fetch feeds and store in temporary file. -sfeedtmpdir="$(mktemp -d '/tmp/sfeed_XXXXXX')" -# make sure path exists. +# make sure sfeed path and temporary directory exist. +mkdir -m 700 -p "${sfeedtmpdir}" mkdir -p "${sfeedpath}" # fetch feeds specified in config file. feeds -- cgit v1.2.3