From 867da67971aa484d875f813a8dc07bd2a365b235 Mon Sep 17 00:00:00 2001 From: Benjamin Chausse Date: Tue, 7 Nov 2023 13:17:03 -0500 Subject: Use shutil.which to detect installation on windows --- benchmarking/test-suite/requirements_win.txt | 1 + benchmarking/test-suite/testsweet.py | 8 ++++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/benchmarking/test-suite/requirements_win.txt b/benchmarking/test-suite/requirements_win.txt index 645fea3..a9855d0 100644 --- a/benchmarking/test-suite/requirements_win.txt +++ b/benchmarking/test-suite/requirements_win.txt @@ -1 +1,2 @@ +winapps windows-curses diff --git a/benchmarking/test-suite/testsweet.py b/benchmarking/test-suite/testsweet.py index 0bab25d..639d8ad 100755 --- a/benchmarking/test-suite/testsweet.py +++ b/benchmarking/test-suite/testsweet.py @@ -158,7 +158,11 @@ class Windows(OS): def is_installed(self, package): # Check if the package is installed on the system with where - return os.system(f"where {package}") == 0 + if shutil.which(package) is not None: + return True + else: + return False + # return os.system(f"where {package}") == 0 def install(self, package, force=False): # Cd into the cachedir @@ -436,7 +440,7 @@ def main(): if not host.is_installed("glances"): warnings.warn("glances is not installed. "+ " Monitoring will be disabled.\n"+ - "Consider installing it with pip install requirements.txt."+ + "Consider running pip install -r requirements.txt."+ "On windows, also use requirements_win.txt.") monitor = False host.run(test, iterations, monitor) -- cgit v1.2.3