diff options
author | Hiltjo Posthuma <hiltjo@codemadness.org> | 2015-08-14 17:03:53 +0200 |
---|---|---|
committer | Hiltjo Posthuma <hiltjo@codemadness.org> | 2015-08-14 17:03:53 +0200 |
commit | 6bc48bb27a50d711cb104d010998a1c1cee6e8d2 (patch) | |
tree | 8e772ba8622d050c749cc8582084c9169b906b3d | |
parent | 84831ac69e9a20800a50a902aa5e7000168f3d45 (diff) |
minor code-style improvements
-rw-r--r-- | sfeed.c | 2 | ||||
-rwxr-xr-x | sfeed_update | 4 | ||||
-rw-r--r-- | xml.c | 9 |
3 files changed, 7 insertions, 8 deletions
@@ -147,7 +147,7 @@ gettag(enum FeedType feedtype, const char *name, size_t namelen) for (i = 0; tags[i].name; i++) { if (!(n = strcasecmp(tags[i].name, name))) return tags[i].id; /* found */ - /* optimization: it's sorted so nothing after it matches. */ + /* optimization: tags are sorted so nothing after matches. */ if (n > 0) return TagUnknown; } diff --git a/sfeed_update b/sfeed_update index c2c91bc..99cb517 100755 --- a/sfeed_update +++ b/sfeed_update @@ -42,9 +42,9 @@ merge() { # fetchfeed(url, name, feedfile) fetchfeed() { if curl -f -s -S --max-time 15 -z "$3" "$1"; then - printf " OK %s %s\n" "`date +'%H:%M:%S'`" "$2" >&2 + printf " OK %s %s\n" "$(date +'%H:%M:%S')" "$2" >&2 else - printf "FAIL %s %s\n" "`date +'%H:%M:%S'`" "$2" >&2 + printf "FAIL %s %s\n" "$(date +'%H:%M:%S')" "$2" >&2 fi } @@ -388,20 +388,19 @@ xml_parse(XMLParser *x) if (c == '>') break; else if (c == '-' && tagdatalen == sizeof("--") - 1 && - (x->data[0] == '-')) { /* comment */ + (x->data[0] == '-')) { xml_parsecomment(x); break; } else if (c == '[') { if (tagdatalen == sizeof("[CDATA[") - 1 && - x->data[1] == 'C' && x->data[2] == 'D' && - x->data[3] == 'A' && x->data[4] == 'T' && - x->data[5] == 'A' && x->data[6] == '[') { /* CDATA */ + !strncmp(x->data, "[CDATA[", tagdatalen)) { xml_parsecdata(x); break; } } } - } else { /* normal tag (open, short open, close), processing instruction. */ + } else { + /* normal tag (open, short open, close), processing instruction. */ if (isspace(c)) while ((c = xml_getnext(x)) != EOF && isspace(c)) ; |