diff options
| author | Hiltjo Posthuma <hiltjo@codemadness.org> | 2022-03-14 13:25:52 +0100 |
|---|---|---|
| committer | Hiltjo Posthuma <hiltjo@codemadness.org> | 2022-03-14 13:25:52 +0100 |
| commit | b6f7a3fe15f2f253a1653454f514b467aa20f821 (patch) | |
| tree | c0fdddaa251dbb0a4da66a86b547032bb84d3bc8 /sfeed_curses.c | |
| parent | 3dbdf1ccfa5f109f8d7489f913ed57aa8e9b5f11 (diff) | |
improve time(NULL) error checking
Use errx, time(NULL) does not set errno. For sfeed_curses reset errno so it
doesn't print a random error if it failed.
POSIX recommends checking against (time_t)-1 on failure.
Note that some implementation, like the OpenBSD man page says time() cannot
fail.
Diffstat (limited to 'sfeed_curses.c')
| -rw-r--r-- | sfeed_curses.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sfeed_curses.c b/sfeed_curses.c index 4d77504..1c6bc24 100644 --- a/sfeed_curses.c +++ b/sfeed_curses.c @@ -1308,7 +1308,8 @@ feeds_load(struct feed *feeds, size_t nfeeds) struct feed *f; size_t i; - if ((comparetime = time(NULL)) == -1) + errno = 0; + if ((comparetime = time(NULL)) == (time_t)-1) die("time"); /* 1 day is old news */ comparetime -= 86400; |