Age | Commit message (Collapse) | Author |
|
Passing NULL to wlr_keyboard_set_keymap results in a segfault.
Example:
Thread 1 "dwl" received signal SIGSEGV, Segmentation fault.
0x00007ffff7e49b64 in xkb_keymap_ref () from /usr/lib/libxkbcommon.so.0
(gdb) bt
#0 0x00007ffff7e49b64 in xkb_keymap_ref () at /usr/lib/libxkbcommon.so.0
#1 0x00007ffff7f06389 in wlr_keyboard_set_keymap () at /usr/lib/libwlroots.so.11
#2 0x000055555555bc54 in createkeyboard ()
#3 0x000055555555c283 in inputdevice ()
#4 0x00007ffff7e8101e in wl_signal_emit_mutable () at /usr/lib/libwayland-server.so.0
#5 0x00007ffff7e8101e in wl_signal_emit_mutable () at /usr/lib/libwayland-server.so.0
#6 0x00007ffff7edb52c in () at /usr/lib/libwlroots.so.11
#7 0x00007ffff7ee44b6 in () at /usr/lib/libwlroots.so.11
#8 0x000055555555fe66 in main ()
|
|
Closes: https://github.com/djpohly/dwl/issues/427
|
|
Note that previous df131cdb78c6e3e79c3fafa522f0e4f6b43d2ab4 libX11 headers
were also required for building (but not for runtime)
Also, I want to apologize to the packagers for do not list *all* the required
dependencies before.
|
|
these things were changed in the code but not in the readme
|
|
For some reason brave configured for as a wayland client triggers this code on startup and segfaults.
Checking if the client is mapped fixes this, like with the previous fix for urgent border colour.
References: 887fde65a3010905aa10f373cfcfe540cfc1781e
Fixes: 72a7d78a1a7926a207539eb50f44b2e1eb089d49
|
|
|
|
this fixes a segfault when the client emits .set_hints but it's not mapped
Fixes: 72a7d78a1a7926a207539eb50f44b2e1eb089d49
|
|
I'm going to make some changes in the config file anyway
This reverts commit e5367753bb90add013ee5d170a110064298ac2c4.
|
|
|
|
|
|
iirc this is the same behavior of dwm
|
|
|
|
|
|
Closes: https://github.com/djpohly/dwl/issues/466
|
|
Closes: https://github.com/djpohly/dwl/issues/487
|
|
is true
Bug: https://github.com/djpohly/dwl/issues/487
|
|
|
|
|
|
|
|
|
|
since in the previous commit we may not applying floating in clients
this is to make sure we do
|
|
there is still a bug, but for now this prevents a segfault
Bug: https://github.com/djpohly/dwl/issues/472
|
|
I regularly check the discord server, but it is much more likely that I will be
online on IRC, and djpohly does not seem to be active on either.
|
|
|
|
|
|
we do not use the node
|
|
Use an early return to avoid indenting the main logic instead of
wrapping the tail of a function in an if statement.
No functional change, except for a handful of places where printstatus()
was being called spuriously (tag, toggletag, toggleview).
ΔSLOC: 0
|
|
The scene graph implementation sends these for us, and it does so more
accurately than our overly-simplified approach. Layer shell surfaces
don't appear to receive these events at all, according to my
WAYLAND_DEBUG experiments with bemenu and dtao.
ΔSLOC: -4
|
|
It creates an infinite commit-resize loop when scale != 1
|
|
ΔSLOC: -4
Fixes: https://github.com/djpohly/dwl/issues/456
Fixes: https://github.com/djpohly/dwl/issues/459
|
|
This appears to have been here for the side effect of updating the drag
icon's position.
|
|
|
|
If there is no current drag icon, this node will be empty, but we now
have `drag_icon != NULL` as an invariant. This allows us to eliminate a
conditional, since there's no harm in moving an empty node's coordinates
around with the pointer.
ΔSLOC: -1
|
|
ΔSLOC: +1
|
|
Merge our signal handlers into a single function and let Wayland deal
with all the struct sigaction stuff.
ΔSLOC: -3
|
|
If we treat the drag icon as distinct from other layers (it doesn't have
contents that are interactive, focusable, etc.), then we can iterate
over layers meaningfully with a simple for loop.
ΔSLOC: -8
|
|
It added complexity, especially with the differences in behavior between
handled and ignored signals across an exec().
|
|
|
|
Ignored handlers are not reset by exec() calls
|
|
|
|
Fixes an issue when swaylock does not receive input after turn off and then
turn on the outputs
|
|
Bug: https://github.com/djpohly/dwl/issues/420
Fixes: https://github.com/djpohly/dwl/issues/353
|
|
|
|
I am no longer able to spend much time developing dwl let alone maintaining
other's patches :)
|
|
Closes: https://github.com/djpohly/dwl/issues/408
|
|
outputs
|
|
checking only wlr_scene_node.enabled may result in a false positive because it
does not consider if its ancestors are enabled as well.
|
|
arrange must never be called with a NULL argument
|
|
|
|
while the size of `int` in most compilers is 32-bits, the size of int and all
other integer types are implementation defined, so make sure we can use up to
32-bits
|